feat: use shared informers to watch resource #615
Conversation
adityathebe
force-pushed
the
feat/use-shared-informers-to-watch-resources
branch
from
1e053b1 to
d45e1a2
Compare
| @@ -38,6 +40,18 @@ import ( | |||
| "k8s.io/client-go/util/homedir" | |||
| ) | |||
|
|
|||
| var kubeClientCreatedCount = prometheus.NewCounterVec( | |||
There was a problem hiding this comment.
Should this be a ctx.Counter() ?
There was a problem hiding this comment.
kube client creation is called in a bunch of places and they don't pass in the context. So I did it this way.
adityathebe
force-pushed
the
feat/use-shared-informers-to-watch-resources
branch
2 times, most recently
from
9f05144 to
76fa84c
Compare
| ) | ||
|
|
||
| // WatchResources watches Kubernetes resources | ||
| func getUnstructuredFromInformedObj(resource v1.KubernetesResourceToWatch, obj any) (*unstructured.Unstructured, error) { | ||
| b, err := json.Marshal(obj) |
There was a problem hiding this comment.
Why do we need to marshal and unmarshall - It should be unstructured already ?
There was a problem hiding this comment.
No, we receive concrete types like core v1.Pod
| } | ||
| } | ||
|
|
||
| factory := informers.NewSharedInformerFactory(ctx.Kubernetes(), 0) |
There was a problem hiding this comment.
Is this already prepopulated with kubeconfigs client ?
There was a problem hiding this comment.
ya we set it here
config-db/scrapers/kubernetes/events_watch.go
Line 134 in fd1e448
adityathebe
force-pushed
the
feat/use-shared-informers-to-watch-resources
branch
from
76fa84c to
8c65ceb
Compare
|
🎉 This PR is included in version 0.0.318 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.